Browse Source

2005-10-23 Paul Jakma <paul.jakma@sun.com>

	* ospf_apiserver.c: (ospf_apiserver_term) This function should
	  not have side-effects (eg segv) if no apiserver instances are
	  active, ie be robust.
paul 15 years ago
parent
commit
e029d44858
2 changed files with 7 additions and 2 deletions
  1. 3 0
      ospfd/ChangeLog
  2. 4 2
      ospfd/ospf_apiserver.c

+ 3 - 0
ospfd/ChangeLog

@@ -1,5 +1,8 @@
 2005-10-23 Paul Jakma <paul.jakma@sun.com>
 
+	* ospf_apiserver.c: (ospf_apiserver_term) This function should
+	  not have side-effects (eg segv) if no apiserver instances are
+	  active, ie be robust.
 	* ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
 	  has not yet been run.
 

+ 4 - 2
ospfd/ospf_apiserver.c

@@ -189,11 +189,13 @@ ospf_apiserver_term (void)
    * Free all client instances.  ospf_apiserver_free removes the node
    * from the list, so we examine the head of the list anew each time.
    */
-  while ( (apiserv = listgetdata (listhead (apiserver_list))) != NULL)
+  while ( apiserver_list &&
+         (apiserv = listgetdata (listhead (apiserver_list))) != NULL)
     ospf_apiserver_free (apiserv);
 
   /* Free client list itself */
-  list_delete (apiserver_list);
+  if (apiserver_list)
+    list_delete (apiserver_list);
 
   /* Free wildcard list */
   /* XXX  */