Browse Source

[ripngd] CID #72, remove unneeded NULL check

2006-05-11 Paul Jakma <paul.jakma@sun.com>

	* ripng_interface.c: (ripng_interface_address_add) Remove
	  unneeded NULL check, Coverity CID #72.
Paul Jakma 16 years ago
parent
commit
995b96515b
2 changed files with 14 additions and 11 deletions
  1. 5 0
      ripngd/ChangeLog
  2. 9 11
      ripngd/ripng_interface.c

+ 5 - 0
ripngd/ChangeLog

@@ -1,3 +1,8 @@
+2006-05-11 Paul Jakma <paul.jakma@sun.com>
+
+	* ripng_interface.c: (ripng_interface_address_add) Remove
+	  unneeded NULL check, Coverity CID #72.
+
 2006-05-08 Paul Jakma <paul.jakma@sun.com>
 
 	* ripng_routemap.c: (route_set_ipv6_nexthop_local_compile) bug

+ 9 - 11
ripngd/ripng_interface.c

@@ -435,6 +435,8 @@ ripng_interface_address_add (int command, struct zclient *zclient,
 
   if (p->family == AF_INET6)
     {
+      struct ripng_interface *ri = c->ifp->info;
+      
       if (IS_RIPNG_DEBUG_ZEBRA)
 	zlog_debug ("RIPng connected address %s/%d add",
 		   inet6_ntoa(p->u.prefix6),
@@ -444,19 +446,15 @@ ripng_interface_address_add (int command, struct zclient *zclient,
       ripng_apply_address_add(c);
 
       /* Let's try once again whether the interface could be activated */
-      if (c->ifp) {
-        struct ripng_interface *ri = c->ifp->info;
-
-        if (!ri->running) {
-          /* Check if this interface is RIP enabled or not.*/
-          ripng_enable_apply (c->ifp);
+      if (!ri->running) {
+        /* Check if this interface is RIP enabled or not.*/
+        ripng_enable_apply (c->ifp);
 
-          /* Apply distribute list to the interface. */
-          ripng_distribute_update_interface (c->ifp);
+        /* Apply distribute list to the interface. */
+        ripng_distribute_update_interface (c->ifp);
 
-          /* Check interface routemap. */
-          ripng_if_rmap_update_interface (c->ifp);
-        }
+        /* Check interface routemap. */
+        ripng_if_rmap_update_interface (c->ifp);
       }
 
     }